Skip to content

refactor: support Sign-on and Javascript runtime template#16372

Merged
xiaolang124 merged 17 commits into
devfrom
refactor/office-new-template
Jul 20, 2026
Merged

refactor: support Sign-on and Javascript runtime template#16372
xiaolang124 merged 17 commits into
devfrom
refactor/office-new-template

Conversation

@xiaolang124

@xiaolang124 xiaolang124 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Office add-in questions:
image

Word:
image
image

PowerPoint:
image

Excel:
image

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

❌ VscUse Test Plan — Tests failure

Why these tests: Changed files include vsc/ts Office Addin templates and scaffold/wizard logic (CapabilityOptions, constructNode, wizardNode.json), so UI scaffold and wizard verification plans are most relevant; no direct match to Teams/bot/tab/DA template paths.

Branch diff: refactor/office-new-templatedev

Plans run:

  • Feature_Verify_Scaffold_Works_For_Dynamically_Added_Template
  • Feature_Verify_Wizard_UI_Loads_All_Project_Types_From_Wizard_Node
  • Feature_UI_Layout__Create_Project_Questions

Step Status
1️⃣ Build VSIX (CD) ✅ Done
2️⃣ Build Docker image ✅ Done
3️⃣ Run UI tests ❌ Tests failure

🔗 Full pipeline results

ℹ️ How were these tests selected?

GitHub Copilot (Claude Sonnet 4.6, high reasoning) analysed the PR title, description, and the diff between
refactor/office-new-template and dev
to pick the most relevant test plans from packages/tests/vscuse/Index.md.

Comment thread packages/fx-core/src/component/generator/officeAddin/generator.ts Fixed
Comment thread packages/fx-core/src/component/generator/officeAddin/generator.ts Fixed

import { createNestablePublicClientApplication, type IPublicClientApplication } from "@azure/msal-browser";

export { AccountManager };

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow template source style.

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

❌ VscUse Test Plan — Tests unknown

Why these tests: PR adds new Office Add-in TypeScript templates (office-addin-excel-customfunctions and office-addin-sso-naa under templates/vsc/ts/) and refactors scaffold/question/generator code; no direct VscUse test plan covers Office Add-in templates, so scaffold/wizard UI feature plans are most relevant for verifying the new templates appear correctly in the project creation wizard.

Branch diff: refactor/office-new-templatedev

Plans run:

  • Feature_Verify_Scaffold_Works_For_Dynamically_Added_Template
  • Feature_Verify_Wizard_UI_Loads_All_Project_Types_From_Wizard_Node
  • Feature_UI_Layout__Create_Project_Questions

Step Status
1️⃣ Build VSIX (CD) ✅ Done
2️⃣ Build Docker image ✅ Done
3️⃣ Run UI tests ❌ Tests unknown
ℹ️ How were these tests selected?

GitHub Copilot (Claude Sonnet 4.6, high reasoning) analysed the PR title, description, and the diff between
refactor/office-new-template and dev
to pick the most relevant test plans from packages/tests/vscuse/Index.md.

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

E2E Test Selection — AI Selected

Why these tests: fx-core scaffold infrastructure changes (CapabilityOptions, constructNode, questionNames) and new Office Add-in templates have no dedicated e2e tests, so basic scaffold tests covering bot/tab/message-extension creation flows plus multienv are selected as representatives per the fx-core mapping rule.

Cases selected (4):

  • ./teamsApp/basicBot.tests.ts
  • ./teamsApp/basicTab.tests.ts
  • ./teamsApp/basicMessageExtension.tests.ts
  • ./feature/multienv.tests.ts

View pipeline run

Need to run more tests?

Comment on this PR:

  • /e2e-run ./path/to/test.tests.ts — add specific cases to AI selection
  • /e2e-run-all — run all e2e cases

Then re-run the workflow.

"template.importOfficeAddin.label": "Upgrade existujícího doplňku pro Office",
"template.newCFShortcut.detail": "Doplněk podokna úloh s vlastní funkcí a klávesovou zkratkou",
"template.newCFShortcut.label": "Vlastní funkce a zástupce",
"template.newCFShortcut.detail": "Create custom functions in Excel using a shared runtime",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't manually update the localized files. Only change the package.nls.json and the localization pipeline will handle other files.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -0,0 +1,60 @@
# yaml-language-server: $schema=https://aka.ms/m365-agents-toolkits/v1.11/yaml.schema.json
# Visit https://aka.ms/teamsfx-v5.0-guide for details on this file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this template have m365agents.local.yml for local env?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, previously in stable version it does not have local.yml file.
image

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

❌ VscUse Test Plan — Tests failure

Why these tests: PR adds new Office Add-in VS Code TypeScript templates (vsc/ts/office-addin-*) and modifies the scaffold wizard (CapabilityOptions.ts, wizardNode.json), so wizard UI and scaffold verification plans are most relevant; no Office-specific VscUse plans exist in the available list.

Branch diff: refactor/office-new-templatedev

Results: ✅ 1 passed · ❌ 2 failed (of 3 plans)

Plans run:

  • Feature_Verify_Wizard_UI_Loads_All_Project_Types_From_Wizard_Node
  • Feature_Verify_Scaffold_Works_For_Dynamically_Added_Template
  • Feature_UI_Layout__Create_Project_Questions

Step Status
1️⃣ Build VSIX (CD) ✅ Done
2️⃣ Build Docker image ✅ Done
3️⃣ Run UI tests ❌ Tests failure (1/3 passed)

🎯 Actual UI test run
🔗 Full pipeline results
📊 Detailed test report

ℹ️ How were these tests selected?

GitHub Copilot (Claude Sonnet 4.6, high reasoning) analysed the PR title, description, and the diff between
refactor/office-new-template and dev
to pick the most relevant test plans from packages/tests/vscuse/Index.md.

qfai
qfai previously approved these changes Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

❌ VscUse Test Plan — Tests failure

Why these tests: PR adds new Office add-in templates under templates/vsc/ts/ (no dedicated plan exists) and modifies packages/fx-core scaffold/wizard files (CapabilityOptions.ts, wizardNode.json, questionNames.ts), so scaffold verification and wizard UI plans are most relevant, plus one smoke plan as sanity check.

Branch diff: refactor/office-new-templatedev

Results: ✅ 2 passed · ❌ 2 failed (of 4 plans)

Plans run:

  • Feature_Verify_Scaffold_Works_For_Dynamically_Added_Template
  • Feature_Verify_Wizard_UI_Loads_All_Project_Types_From_Wizard_Node
  • Feature_UI_Layout__Create_Project_Questions
  • Basic_Custom_Engine_Azure_OpenAI_ts_Copilot_Remote_Debug

Step Status
1️⃣ Build VSIX (CD) ✅ Done
2️⃣ Build Docker image ✅ Done
3️⃣ Run UI tests ❌ Tests failure (2/4 passed)

🎯 Actual UI test run
🔗 Full pipeline results
📊 Detailed test report

ℹ️ How were these tests selected?

GitHub Copilot (Claude Sonnet 4.6, high reasoning) analysed the PR title, description, and the diff between
refactor/office-new-template and dev
to pick the most relevant test plans from packages/tests/vscuse/Index.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants