refactor: support Sign-on and Javascript runtime template#16372
Conversation
…time template name
❌ VscUse Test Plan — Tests failureWhy these tests: Changed files include vsc/ts Office Addin templates and scaffold/wizard logic (CapabilityOptions, constructNode, wizardNode.json), so UI scaffold and wizard verification plans are most relevant; no direct match to Teams/bot/tab/DA template paths. Branch diff: Plans run:
ℹ️ How were these tests selected?GitHub Copilot (Claude Sonnet 4.6, high reasoning) analysed the PR title, description, and the diff between |
|
|
||
| import { createNestablePublicClientApplication, type IPublicClientApplication } from "@azure/msal-browser"; | ||
|
|
||
| export { AccountManager }; |
There was a problem hiding this comment.
Follow template source style.
❌ VscUse Test Plan — Tests unknownWhy these tests: PR adds new Office Add-in TypeScript templates (office-addin-excel-customfunctions and office-addin-sso-naa under templates/vsc/ts/) and refactors scaffold/question/generator code; no direct VscUse test plan covers Office Add-in templates, so scaffold/wizard UI feature plans are most relevant for verifying the new templates appear correctly in the project creation wizard. Branch diff: Plans run:
ℹ️ How were these tests selected?GitHub Copilot (Claude Sonnet 4.6, high reasoning) analysed the PR title, description, and the diff between |
E2E Test Selection — AI SelectedWhy these tests: fx-core scaffold infrastructure changes (CapabilityOptions, constructNode, questionNames) and new Office Add-in templates have no dedicated e2e tests, so basic scaffold tests covering bot/tab/message-extension creation flows plus multienv are selected as representatives per the fx-core mapping rule. Cases selected (4):
Need to run more tests?Comment on this PR:
Then re-run the workflow. |
| "template.importOfficeAddin.label": "Upgrade existujícího doplňku pro Office", | ||
| "template.newCFShortcut.detail": "Doplněk podokna úloh s vlastní funkcí a klávesovou zkratkou", | ||
| "template.newCFShortcut.label": "Vlastní funkce a zástupce", | ||
| "template.newCFShortcut.detail": "Create custom functions in Excel using a shared runtime", |
There was a problem hiding this comment.
Don't manually update the localized files. Only change the package.nls.json and the localization pipeline will handle other files.
| @@ -0,0 +1,60 @@ | |||
| # yaml-language-server: $schema=https://aka.ms/m365-agents-toolkits/v1.11/yaml.schema.json | |||
| # Visit https://aka.ms/teamsfx-v5.0-guide for details on this file | |||
There was a problem hiding this comment.
Does this template have m365agents.local.yml for local env?
❌ VscUse Test Plan — Tests failureWhy these tests: PR adds new Office Add-in VS Code TypeScript templates (vsc/ts/office-addin-*) and modifies the scaffold wizard (CapabilityOptions.ts, wizardNode.json), so wizard UI and scaffold verification plans are most relevant; no Office-specific VscUse plans exist in the available list. Branch diff: Results: ✅ 1 passed · ❌ 2 failed (of 3 plans) Plans run:
ℹ️ How were these tests selected?GitHub Copilot (Claude Sonnet 4.6, high reasoning) analysed the PR title, description, and the diff between |
bd4b3b9
❌ VscUse Test Plan — Tests failureWhy these tests: PR adds new Office add-in templates under templates/vsc/ts/ (no dedicated plan exists) and modifies packages/fx-core scaffold/wizard files (CapabilityOptions.ts, wizardNode.json, questionNames.ts), so scaffold verification and wizard UI plans are most relevant, plus one smoke plan as sanity check. Branch diff: Results: ✅ 2 passed · ❌ 2 failed (of 4 plans) Plans run:
ℹ️ How were these tests selected?GitHub Copilot (Claude Sonnet 4.6, high reasoning) analysed the PR title, description, and the diff between |

Office add-in questions:

Word:


PowerPoint:

Excel:
