fix(security): bump adm-zip to ^0.6.0 to resolve GHSA-xcpc-8h2w-3j85#16375
Open
sebastienlevert wants to merge 1 commit into
Open
fix(security): bump adm-zip to ^0.6.0 to resolve GHSA-xcpc-8h2w-3j85#16375sebastienlevert wants to merge 1 commit into
sebastienlevert wants to merge 1 commit into
Conversation
adm-zip < 0.6.0 is vulnerable to denial of service (GHSA-xcpc-8h2w-3j85): a crafted ZIP that declares a ~4GB uncompressed size in its central directory header triggers an unbounded Buffer.alloc before CRC validation, crashing the process. Bump every direct adm-zip declaration to the patched 0.6.0 release. @types/adm-zip is intentionally left unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 04c8c99b-b190-431f-ad6a-1ae9a014a852
sebastienlevert
requested review from
Alive-Fish,
HuihuiWu-Microsoft,
Sherylueen,
qfai,
qinqingxu,
qinzhouxu,
tecton,
wh-alice and
yuqizhou77
as code owners
July 18, 2026 02:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps every direct
adm-zipdeclaration to^0.6.0to resolve GHSA-xcpc-8h2w-3j85 (high severity, denial of service).adm-zipbefore0.6.0allocates memory based on the uncompressed size declared in a ZIP central-directory header without bounds-checking it against the actual compressed data, and the allocation happens before CRC validation. A crafted ~120-byte ZIP declaring ~4GB uncompressed size causes an allocation-amplification of >33,000,000:1, crashing the process. All extraction/read paths are affected (readFile,readAsText,extractEntryTo,extractAllTo,extractAllToAsync,test,entry.getData). The vulnerability was surfaced bypnpm auditin a downstream consumer, whereadm-zipis pulled in transitively via@microsoft/teamsfx-core.Changes
packages/fx-core/package.json^0.5.10^0.6.0packages/sdk/package.json^0.5.9^0.6.0templates/package.json^0.5.10^0.6.0packages/tests/package.json0.5.100.6.0@types/adm-zipis intentionally left unchanged — only the runtime dependency is affected by the advisory.Notes
0.6.0is the only published release in the advisory's patched range (>=0.6.0); it is the currentlateston npm.adm-zipdeclarations. The advisory can also reach ATK transitively through@microsoft/kiotaandoffice-addin-manifest; those live in separate upstream packages and are out of scope for this repo.Security advisory
adm-zip@0.6.0.