Skip to content

Update dotnet monorepo #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoeRobich merged 1 commit into from
Sep 25, 2023
Merged

Update dotnet monorepo #1031

JoeRobich merged 1 commit into from
Sep 25, 2023

Conversation

@manandre
Copy link
Contributor

@manandre manandre commented Sep 24, 2023

No description provided.

@github-actions github-actions bot added this to the v0.19.10 milestone Sep 24, 2023
@manandre
Copy link
Contributor Author

manandre commented Sep 24, 2023 

[xUnit.net 00:00:17.92] Lsp.Integration.Tests.PartialItemsTests+Delegates.Should_Behave_Like_A_Task [FAIL]

Only happen on Ubuntu build, I cannot reproduce locally (via WSL2 on Ubuntu 22.04).
Could it be a flaky test?
@JoeRobich Can you please relaunch it?

JoeRobich
JoeRobich approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manandre!

@JoeRobich JoeRobich merged commit ae60c12 into OmniSharp:master Sep 25, 2023
@github-actions github-actions bot added the mysterious We forgot to label this label Sep 25, 2023
@manandre manandre deleted the dotnet-monorepo branch September 25, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees

No one assigned

Labels

mysterious We forgot to label this

Projects

None yet

Milestone

v0.19.10

Development

Successfully merging this pull request may close these issues.

2 participants

@manandre @JoeRobich