expression_language package mods for updated rational and other deps#114
Open
timmaffett wants to merge 1 commit into
Open
expression_language package mods for updated rational and other deps#114timmaffett wants to merge 1 commit into
timmaffett wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull primarily modifies the expression_language package to work with the current versions of the dependencies.
It primarily modifies
decimal.dartto work with current rational package.It does add a new
passed_in_old_version.featurefile which contains one of the previous tests which no longer passes. I believe this must be because of a change within the petite_parser package. I was able to modify this test within the existingexpressions_can_solve.featurefile in line 652 by adding parentheses around the ! subject.With the addition of the parentheses all tests pass once again with this version. It was not a requirement for me to have the previous test pass so I did not get to the bottom of the required fixes to the gramar to make the previous test pass again with the new petite_parser.
TLDR:
When expression "!@testElement.nullableBoolValue!" is evaluatedbecame
When expression "!(@testElement.nullableBoolValue!)" is evaluatedThe contents of the new
passed_in_old_version.featurefile is included below to highlight the need to possibly fix the gramar for the new petite_parser package to this test passes once again.passed_in_old_version.featurefile which contains test which passes in previous version: