Revert feature flag to enable/disable content hash cleanup#1966
Open
Revert feature flag to enable/disable content hash cleanup#1966
Conversation
The `feature_stable_consent_hash_migration` feature flag was confusing, and setting the old hash to null provided no real value
johanib
force-pushed
the
feature/cleanup-feature-flag
branch
from
01dd4be to
882403b
Compare
kayjoosten
requested changes
Apr 9, 2026
Contributor
kayjoosten
left a comment
kayjoosten
left a comment
There was a problem hiding this comment.
I miss the migration where we make the consent hash nullable that is not needed anymore after this change right?
Contributor
Author
With this change, we no longer generate the old hashes? New hashes are always the stable hashes. So new users insert null into the old hash column? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
feature_stable_consent_hash_migrationfeature flag was confusing, and setting the old hash to null provided no real value