fix(storage): reject flushing lazy source step - #530
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent
LazyFileStorage.flush_step()from flushing step 0 or negative steps.Step 0 represents the original input source rather than a writable cache output. Explicitly flushing it could serialize the source using
cache_typeand replace the original file, potentially changing its format or contents.Changes
flush_step(step)whenstep <= 0with a detailedValueError.write()are valid.flush_step(0)raises the expected error;Context
PR #527 protected source files from automatic
flush_all()calls by limiting them to dirty output steps. This follow-up closes the remaining explicitflush_step(0)path without expanding into a broader storage lifecycle refactor.