fix: make push resilient on slow uploads and prevent duplicate upload#629
Merged
Merged
Conversation
…ate attachment uploads
r0ssing
approved these changes
May 7, 2026
Contributor
r0ssing
left a comment
There was a problem hiding this comment.
LGTM! Thanks @najuna-brian
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves Desktop sync reliability for slow or unstable internet connections, especially when observations include attachment files.
Before this change, sync could fail because attachment upload and observation push had fixed client-side timeouts, and retries could re-run expensive attachment upload work even when files had already been uploaded. The UI could also look inconsistent (for example, showing
0pending queued attachments while still running attachment preflight for observation-referenced files).This PR makes push more resilient and reduces duplicate work by:
What changed
desktop/src/store/useCustodianStore.tsuploadOutboundAttachments(...)syncGateway.push(...)localStoragefailed > 0Test plan
failed == 0.failed > 0) still blocks push with clear error.