Skip to content

Remove platform specific data and update memory map#77

Closed
philgweber wants to merge 2 commits into
OpenDevicePartnership:mainfrom
philgweber:main
Closed

Remove platform specific data and update memory map#77
philgweber wants to merge 2 commits into
OpenDevicePartnership:mainfrom
philgweber:main

Conversation

@philgweber

Copy link
Copy Markdown
Collaborator

Removed all the platform code as we want this in the platform specific repos.

Now that we've switched to ARM_VIRT rather than SBSA updated all the addresses for TPM. Need to review how to expose these addresses in a cleaner way based on platform rather than hard coding in the code as they are today.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Cargo Vet Audit Failed

cargo vet has failed in this PR. Please run cargo vet --locked locally to check for new or updated unvetted dependencies.
Details about the vetting process can be found in supply-chain/README.md

If the unvetted dependencies are not needed

Please modify Cargo.toml file to avoid including the dependencies.

If the unvetted dependencies are needed

Post a new comment with the questionnaire below to the PR to help the auditors vet the dependencies.
After the auditors have vetted the dependencies, the PR will need to be rebased to pick up the new audits and pass this check.

Copy and paste the questionnaire as a new comment and provide your answers:

1. What crates (with version) need to be audited?

2. How many of the crates are version updates vs new dependencies?

3. To confirm none of the already included crates serve your needs, please provide a brief description of the purpose of the new crates.

4. Any extra notes to the auditors to help with their audits.

kurtjd
kurtjd previously approved these changes Jun 8, 2026

@kurtjd kurtjd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though looks like the workspace Cargo.toml needs to be updated now that some folders are deleted.

active_locality: NO_ACTIVE_LOCALITY,
interface_id_default: PtpCrbInterfaceIdentifier::new(),
locality_states: [TpmLocalityState::Closed; NUM_LOCALITIES as usize],
tpm_internal_crb_address: 0x10000200000,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Raymond-MS cleaned up some of the usage here: 54439c7.

nit: Should we set the default to 0 instead?

@philgweber

Copy link
Copy Markdown
Collaborator Author

I'm going to close this and re-open after several other changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants