Repository navigation
Run gdalinfo from the ODM image and add runner checks - #16
Merged
Merged
Conversation
The brighton "all flags" check called whatever gdalinfo the runner had on PATH. On the CI runner that resolves to a miniconda GDAL whose libgdal fails to load (undefined symbol sqlite3_total_changes64), so the test failed after ODM had exited 0. odm_tool runs a command from the image under test with the output directory mounted at /dataset, so the check uses the GDAL that ODM was built against and the host no longer needs GDAL installed. It sources the pixi shell hook where the image has one and otherwise adds SuperBuild/install/bin to PATH, so it works against both the pixi images (edge) and the 3.6.x images that latest still points at. ./run's environment check and docs/ci.md drop gdalinfo from the requirements.
The 2026-08-25 run failed every test with ENOSPC creating bats' tmpdir. The runner had warned "Free space left: 0 MB" during the edge pull, but the log gave no way to tell which filesystem filled or by how much. Print df and docker system df before the pull, and drop dangling layers from earlier pulls first.
Prints df, docker system df, the Docker data root, the image list and the host tools on PATH, and prunes Docker when the prune input is set. Shares the OATS concurrency group so a prune cannot remove the image a suite run is using between datasets.
smathermather
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two failures in oats:
gdalinfois used to test that the files generated from ODM are valid which works locally. However on the runner there is a conflicting version that made it fail (undefined symbol: sqlite3_total_changes64). Instead I've added a wrapper function to use the version inside the ODM image./or/tmpand I'm not sure why. I added a new manual-only workflow to measure disk space, and added somedfoutput to the main one.With 1. oats runs should now pass most of the time. If it doesn't 2. should tell us why.