Draft
Conversation
Add autocomplete as an explicit attr with default "off" on input/1, input_element/1, and textarea_element/1 in new_inputs.ex instead of relying on static HTML attributes that can't be overridden. Add Keyword.put_new(:autocomplete, "off") to password_field/1 and text_field/1 in form.ex. Remove now-redundant per-field autocomplete="off" from sandbox components since the component default handles it. Add ExUnit tests verifying the default and override behaviour for both component systems. Closes #1533
Add explicit autocomplete values to authentication forms so browser autofill works correctly: email, current-password, new-password, given-name, family-name, one-time-code on login, registration, password reset, profile, TOTP/MFA, re-authenticate, first setup, admin user, and book demo forms. Add autocomplete="off" to raw <input> tags that bypass shared components (webhook URL, token display, webhook auth password/API key inputs). Use autocomplete="new-password" on non-auth password fields (credentials, OAuth client ID/secret, webhook auth, Kafka) to prevent Chrome from autofilling saved passwords — Chrome ignores "off" on type="password" fields but respects "new-password".
Add autoComplete="off" to shared form components (TextField, NumberField) and all inline <input> tags across the collaborative editor and other React files including trigger form, cron builder, version picker, search inputs, and manual run panel. Add Vitest tests for TextField and NumberField verifying the autoComplete attribute is rendered.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4631 +/- ##
==========================================
- Coverage 89.63% 89.61% -0.02%
==========================================
Files 444 444
Lines 21558 21565 +7
==========================================
+ Hits 19323 19325 +2
- Misses 2235 2240 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Remove semantically incorrect autocomplete="new-password" from non-password fields (OAuth Client ID, disabled webhook password display), simplify json_schema_body_component conditional, remove redundant autoComplete="off" from ProjectPicker, and fix duplicate autocomplete attribute in new_inputs.ex code clause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR [adds/changes/fixes]... (A description of your work goes here.)
Closes #__
Validation steps
Additional notes for the reviewer
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)