Conversation
Contributor
Author
Problems
|
Contributor
Author
|
@josephjclark suggests we keep v1 as default and then allow users to switch to v2 style |
| <.icon | ||
| name="hero-chevron-right-mini" | ||
| class="h-4 w-4 transition-transform group-open:rotate-90" | ||
| /> Advanced: use legacy JSON config format |
Collaborator
There was a problem hiding this comment.
This is a really nice idea, and we need to bank it because when we make v2 the default, this is probably how we'll want to handle it.
But for now we actually want to leave v1 the default until v2 has had a bit more testing.
| def config_path(repo_connection) do | ||
| repo_connection.config_path || | ||
| "./openfn-#{repo_connection.project_id}-config.json" | ||
| if repo_connection.use_legacy_config do |
Collaborator
There was a problem hiding this comment.
Calling v1 "legacy" internally is still the correct thing to do though :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes sync v2 protocol the default for syncing projects with Github. It still allows users to fallback to the old config.json style by explicitly enabling it.
Currently defaults to v2 but can be switched to v1 style

Closes #4523
Validation steps
openfn.yamlinstead ofopenfn-<project-id>-config.jsonopenfn.yamlis in github with nicely generated content like the example belowExample
openfn.yamlcontentAdditional notes for the reviewer
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)