Add code-review action and fix security-review comment posting#4638
Open
taylordowns2000 wants to merge 2 commits intomainfrom
Open
Add code-review action and fix security-review comment posting#4638taylordowns2000 wants to merge 2 commits intomainfrom
taylordowns2000 wants to merge 2 commits intomainfrom
Conversation
- Add issues:write permission to security-review (was preventing Claude from posting sticky comments via the issues API) - Change fallback step to if: always() so a comment is guaranteed on every run, not just failures - Add new code-review.yml workflow that invokes the /review skill via claude-code-action on every non-draft PR https://claude.ai/code/session_018DKHSmTKWSyWR4iP4tPgcP
Code ReviewSee the workflow run for the raw Claude output. |
Security ReviewClaude hit the max-turns limit or encountered an error before posting findings. See the workflow run for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4638 +/- ##
==========================================
- Coverage 89.63% 89.62% -0.02%
==========================================
Files 444 444
Lines 21558 21558
==========================================
- Hits 19324 19321 -3
- Misses 2234 2237 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Update model from deprecated claude-opus-4-6 to claude-opus-4-7 in both workflows (root cause of the fast failure on #4638) - Also flatten claude_args to a single line to avoid YAML newline parsing issues - Replace Skill tool invocation in code-review prompt with direct review instructions (the /review skill is interactive-only, unavailable in claude-code-action's non-interactive --prompt mode) https://claude.ai/code/session_018DKHSmTKWSyWR4iP4tPgcP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from posting sticky comments via the issues API)
every run, not just failures
claude-code-action on every non-draft PR
https://claude.ai/code/session_018DKHSmTKWSyWR4iP4tPgcP