fix(deps): approve @parcel/watcher build script - #103
Merged
Merged
Conversation
pnpm refuses the entire install with ERR_PNPM_IGNORED_BUILDS because @parcel/watcher (a transitive dependency of jest-haste-map, used only for fast filesystem watching in Jest's --watch mode) isn't in allowBuilds. CI doesn't use --watch mode, so the native binding is never exercised, but pnpm still blocks the whole install until every build script is explicitly reviewed. @parcel/watcher is the official MIT-licensed package from the Parcel bundler project; its install script just builds/fetches its native binding, same pattern as unrs-resolver/esbuild already allowed here. Verified with a clean install + the full CI suite (format, lint, typecheck, 268 tests) on the jest-bump branch this was blocking.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed change is scoped, documented, and has no unresolved blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
Approves @parcel/watcher’s native build script so pnpm installs complete with the updated Jest dependency tree.
Changes:
- Documents the build rationale.
- Adds
@parcel/watcher: truetoallowBuilds.
| File | Description |
|---|---|
pnpm-workspace.yaml |
Approves the transitive watcher package’s native build script. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm-workspace.yamldidn't have@parcel/watcherinallowBuilds, so pnpm refused the entire install withERR_PNPM_IGNORED_BUILDS- this was blocking the open jest PR (chore(deps): update dependency jest to v30.5.2 #74) and would block any future install once its transitive dependency shows up again.@parcel/watcheris a transitive dependency ofjest-haste-map, used only for fast filesystem watching in Jest's--watchmode (not used by CI). Official MIT-licensed package from the Parcel bundler project; its install script just builds/fetches its native binding, same pattern asunrs-resolver/esbuildalready allowed here.Test plan