Add model package#636
Merged
Merged
Conversation
ajm01
reviewed
Jun 16, 2026
ajm01
left a comment
ajm01
left a comment
Contributor
There was a problem hiding this comment.
found a few nits for you to consider
|
|
||
| Project proj = projectsByName.get(iProject.getName()); | ||
| if (proj.getBuildType() == Project.BuildType.MAVEN && proj.isAggregated()) { | ||
| ProjectModel proj = projectsByName.get(iProject.getName()); |
Contributor
There was a problem hiding this comment.
i looked into any paths coming in here where projectsByName.get(iProject.getName()) could return a null - looks like LaunchConfigurationHelper.getLaunchConfiguration() (line 80) could send in a null iProject? if so should have a null guard after getting the proj value.
Member
Author
There was a problem hiding this comment.
After reviewing the code, i don't see how you get a null here given that you need to select a project to get into this path. This particular method will either be going away or its function will change.
Contributor
There was a problem hiding this comment.
ok - sounds good, just wanted to be certain
| /** | ||
| * Indicates whether this project has been disabled to run on a Liberty server. | ||
| * | ||
| * @return {@code true} if this this project is disabled to run on a Liberty server, {@code false} otherwise. |
mezarin
force-pushed
the
dirStructureUpdate
branch
from
08f97c6 to
0cdec40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds: