feat: migrate smoke and gas detector input plugin to Go - #2662
Open
Wanbogang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the Smoke and Gas Detector input plugin from the deprecated Python runtime (#2481) to Go, per @Prachi1615's request.
Scope
This PR includes the mock connector only. Real hardware backends (Arduino MQ serial, ENS160 I2C, SGP30 I2C) require new Go dependencies not currently in
go.mod, which per CONTRIBUTING.md need discussion in an issue before adding. These will follow in a separate PR.What's included
SmokeGasDetectorinput plugin (plugins/inputs/smoke_gas_detector.go)plugins/inputs/smoke_gas_detector_test.go)config/smoke_gas_detector.json5)Testing
make build✅make vet✅make test— all pass, no regressions ✅