pl-PL: Fix misconverted regional characters#435
Closed
mataha wants to merge 1 commit intoOpenRCT2:masterfrom
Closed
pl-PL: Fix misconverted regional characters#435mataha wants to merge 1 commit intoOpenRCT2:masterfrom
mataha wants to merge 1 commit intoOpenRCT2:masterfrom
Conversation
Self-explanatory; just cp1250 things.
janisozaur
approved these changes
Apr 26, 2026
Member
|
The translations are synced from Localisation, so that PR was enough. As for the encoding: the Polish edition does not use Windows-1250 - it should have, but it uses a mangled version of ISO-8859-1 for all languages. |
Member
|
As mentioned on Discord, the encoding scheme used is not Windows-1250 but a modified ISO-8859-1 (Windows-1252 is derived from this), also used by all other languages. Support may need to be added still, but it’s much more than just an entry in a table. And slot 12 may have been reserved for Polish but isn’t actually used in the Polish version. As the translations are synced, everything we can use from this PR is now present, so I’ll close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excluding mapping
pl-PLto cp1250 in objexport (though I doubt that makes any difference, given Polish strings were extracted using a different method), this is a mirror of OpenRCT2/Localisation#3459.