fix(spp_registry): fix Registrant Tags EvalError on ref() in context#155
Open
fix(spp_registry): fix Registrant Tags EvalError on ref() in context#155
Conversation
The Registrant Tags action used ref() in the context field body which is evaluated client-side in Odoo 19 where ref() is not available. Move to eval attribute which is processed server-side during XML loading. Fixes #879
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the context field in the spp_registry/views/tags_view.xml file to use the eval attribute instead of a text-based dictionary definition. This is a standard improvement in Odoo-style XML views to ensure the context dictionary is correctly evaluated as a Python expression. I have no feedback to provide as there were no review comments to assess.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 19.0 #155 +/- ##
=======================================
Coverage 71.33% 71.33%
=======================================
Files 932 938 +6
Lines 54975 54997 +22
=======================================
+ Hits 39217 39234 +17
- Misses 15758 15763 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
Navigating to Studio > Settings > Registrant Tags throws
EvalError: Name 'ref' is not defined. Theref()function in the action's context field is evaluated client-side in Odoo 19 where it's not available.How was the change implemented?
Moved
ref()from the field body to theevalattribute, which is processed server-side during XML data loading whereref()is available.New unit tests
N/A — XML data fix
How to test manually
Related links