Open
Conversation
rathann
reviewed
Oct 19, 2025
src/FFmpegWriter.cpp
Outdated
| case AV_CODEC_ID_H264: | ||
| video_codec_ctx->max_b_frames = 0; // At least this GPU doesn't support b-frames | ||
| video_codec_ctx->profile = FF_PROFILE_H264_BASELINE | FF_PROFILE_H264_CONSTRAINED; | ||
| video_codec_ctx->profile = AV_PROFILE_H264_BASELINE | AV_PROFILE_H264_BASELINE; |
There was a problem hiding this comment.
You're changing *_H264_CONSTRAINED to *_H264_BASELINE here, is that intentional?
Author
There was a problem hiding this comment.
Of course should be AV_PROFILE_H264_CONSTRAINED
Fixed in 737c9c8
|
FYI, these definitions were deprecated back in FFmpeg 6.1 (FFmpeg/FFmpeg@8238bc0) two years ago. |
rathann
added a commit
to rathann/libopenshot
that referenced
this pull request
Dec 19, 2025
Fixes build with FFmpeg 8, where `FF_PROFILE_*` enums were replaced with `AV_PROFILE_*` and side_data API was replaced with codecpar. References: FFmpeg/FFmpeg@8238bc0 FFmpeg/FFmpeg@5432d2a Supersedes OpenShot#1018 . Fixes OpenShot#1028 .
|
Merge conflicts have been detected on this PR, please resolve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.