Feat: add iframe to proposals#1
Open
Stef-Rousset wants to merge 16 commits into
Open
Conversation
…ame in proposal show
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 Description
This PR adds 2 settings on proposal's component to enable iframe and set the iframe url, and it adds the iframe in the proposal's show page. It also adds a query_params
similartoto the src of the iframe, with the proposal title and proposal body sanitized and escaped.The node version used for this module is 22.14.0, to avoid an error on compilation (
ReferenceError: crypto is not definedlinked to serialize-javascript)Testing
similartothat contains the proposal title and proposal body escaped.Tasks
📷 Screenshots
ONE

TWO

THREE
