Skip to content

Feat: add iframe to proposals#1

Open
Stef-Rousset wants to merge 16 commits into
masterfrom
feat/add_iframe_to_proposals
Open

Feat: add iframe to proposals#1
Stef-Rousset wants to merge 16 commits into
masterfrom
feat/add_iframe_to_proposals

Conversation

@Stef-Rousset
Copy link
Copy Markdown
Collaborator

@Stef-Rousset Stef-Rousset commented May 5, 2026

🎩 Description

This PR adds 2 settings on proposal's component to enable iframe and set the iframe url, and it adds the iframe in the proposal's show page. It also adds a query_params similarto to the src of the iframe, with the proposal title and proposal body sanitized and escaped.
The node version used for this module is 22.14.0, to avoid an error on compilation (ReferenceError: crypto is not defined linked to serialize-javascript)

Testing

  1. As an admin, go to the proposals component configuration page, check "Enable iframe" and provide a url like "https://api.multipod.weblyzard.com/embed/27kVzAqaTFRLZU9v6xBvtHyZcPeURpsg/lite" (screenshot one)
  2. Go to /system, and in the advance settings add in frame src "api.multipod.weblyzard.com"
  3. As a user, go in the FO to a proposal show page and see that the iframe is displayed (screenshot two)
  4. Open your devtools and check that the source of the iframe has a query_params similarto that contains the proposal title and proposal body escaped.

Tasks

  • Add specs

📷 Screenshots

ONE
Capture d’écran 2026-05-06 à 09 57 44

TWO
Capture d’écran 2026-05-06 à 10 00 11

THREE
Capture d’écran 2026-05-06 à 09 59 01

@Stef-Rousset Stef-Rousset marked this pull request as ready for review May 6, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant