Repository navigation
Fixes for API & WQ code review bugs - #950
Merged
Merged
Conversation
Collaborator
Author
|
The CI regression tests fail on the sampletown.inp file because of the fix made for the water quality bug in check valve pipes identified by Claude's WQ-02 issue. EPANET was treating CV pipes as valves with no volume when this is clearly incorrect. WQ-02 provided a simple fix for this which was implemented in this PR and produced a different water quality result for sampletown.inp than that contained in its benchmark output file. To proceed with successfully checking in this PR we need to replace the latter with a corrected version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.