chore(app): add rich text to demo app#1332
Conversation
🟢 Netlify deploy for commit 0ec8e38 succeededDeploy preview: https://6a4526aa0670ff1629b886ef--ouds-android.netlify.app |
c24d801 to
906e926
Compare
7b19955 to
310879b
Compare
310879b to
892ad49
Compare
| status = alertMessageStatus, | ||
| onClose = onClose, | ||
| actionLink = alertMessageActionLink, | ||
| bulletList = bulletList |
There was a problem hiding this comment.
There is a problem in the display of the OudsAlertMessage, the label and the icon are no more centered vertically. I think we should test in OudsAlertMessage if the bullet list is empty.
| <string name="app_tokens_typography_lineHeight_tech" translatable="false">Line height: %s sp</string> | ||
|
|
||
| <!-- Components --> | ||
| <string name="app_components_common_annotatedText_tech" translatable="false">Annotated text</string> |
There was a problem hiding this comment.
Should we display "Annotated text example", because "Annotated text" seems to refer to a parameter?
| bulletList = bulletList.toMutableList().apply { set(index, value) }.toList() | ||
| }, | ||
| enabled = bulletListTextInputsEnabled, | ||
| helperText = stringResource(id = R.string.app_components_common_annotatedTextHelperText_tech) |
There was a problem hiding this comment.
I don't know how to do better but when I tested the app, this helper text suggested me to enter annotated text in the field above but I didn't know how. I needed to scroll to access the "Annotated text" switch.
| description, | ||
| constrainedMaxWidth | ||
| constrainedMaxWidth, | ||
| annotatedText |
There was a problem hiding this comment.
It would be clearer if the "Annotated text example" switch was just after the "Error message" field.
There was a problem hiding this comment.
It is OK if we keep the "Annotated text example" switch last with the new "Supports annotated text. Use switch below for example." wording?
# Conflicts: # core/src/main/java/com/orange/ouds/core/component/OudsAlertMessage.kt
…ol item demo screens
…ot centered vertically when bullet list is empty
f540eaa to
0ec8e38
Compare
2 participants
No description provided.