Repository navigation
Fixes #6 : Save button Light Editor - #23
Osman-Kahraman merged 9 commits into
Conversation
Hazim-AS
changed the title
Osman-Kahraman
left a comment
Osman-Kahraman
left a comment
There was a problem hiding this comment.
Overall, I like the improvements made to the light editor @Hazim-AS. The behavior when closing the window without touching the RGB sliders now correctly avoids saving changes, which aligns with the original issue’s intent.
However, I noticed two logic issues that should probably be addressed.
First, the cancel command only works once. After clicking cancel a single time, the light_editor_prompt dialog is no longer triggered again. Normally it should continue prompting the user until the changes are either saved or discarded.
Second, there is a critical logic issue with the discard flow. If I modify the RGB sliders and then close the light editor window, selecting Discard still ends up saving the changes. In this case the editor should completely revert the changes and avoid persisting them.
To summarize:
- The cancel command should repeatedly trigger the light_editor_prompt until the user explicitly saves or discards.
- When Discard is selected after making changes, the editor should revert the modifications instead of saving them.
Once these logic issues are fixed, the feature should behave exactly as expected and I'm going to merge your PR. Thank you.
| elif self.light_editor_bool: | ||
| coords = list(self.unconverted_objectCoords) | ||
| coords[0] += self.objectSize[0] * self.win_scale | ||
| R_initial, G_initial, B_initial = 0, 0, 0 |
|
Hi, I checked out why the prompt bugged, it was because I put the prompt window on the light_editor window, it should work without problem now since i changed the prompt window position Edit : I also made sure the button of the editor deactivated when the prompt appeared |
Osman-Kahraman
left a comment
Osman-Kahraman
left a comment
There was a problem hiding this comment.
Yes I tested the previous bugs, everything seems good for merge with main.
|
After the CI check, I will merge it. Thank you |
|
Hi, I wanted to improve my commit so I decided to added modulable size and display the value of the size and the color, do you want me to add that ? |
2 participants
Enhancement #6 : Add a save button to the light editor, track dirty state and open prompt if data not saved when quitting the light editor