Repository navigation
Issue 4 - Fixing offset issue when drag and dropping - #29
Merged
Merged
Conversation
pep666
changed the title
Osman-Kahraman
approved these changes
May 9, 2026
Osman-Kahraman
left a comment
Osman-Kahraman
left a comment
Owner
There was a problem hiding this comment.
Thank you for the fixing
| coords = tuple( | ||
| np.array(self.cursor_pos) - (np.array(self.drag_and_dropping.item_collision_coords) * self.win_scale) | ||
| ) | ||
| coords = self.cursor_pos |
Owner
There was a problem hiding this comment.
great idea, I wasn't thinking it will be that simple :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now in designer mod the assets you want to place are at the same position with no offset, the asset is not centered with the cursor though but set on the top left of the asset's image.
Edit done :
In file "game_engine/ui/designer.py", i removed the tuple for the coordonates and changed it to be on the cursor position.