Skip to content

refactor(x): migrate config URL consumers to registry - #652

Merged
fortuna merged 1 commit into
feat/smart-configurl-registryfrom
refactor/configurl-registry-consumers
Oct 29, 2026
Merged

fortuna merged 1 commit into
feat/smart-configurl-registryfrom
refactor/configurl-registry-consumers

Conversation

@fortuna

@fortuna fortuna commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Merged into #647 (feat/smart-configurl-registry). SDK tools, examples, and existing SmartDialer/Mobileproxy construction now use NewDefaultRegistry, New[T], and RegisterBase.

The combined #647 contains the registry API, deprecations, and these caller migrations, resolving the deprecated-API errors in CI. SmartDialer/Mobileproxy extension options remain in #649, stacked directly on #647.

The connectivity tool preserves its tracing dialer lifetime and per-operation tracing. This migration still uses local registries in SmartDialer; configurable shared registries are introduced separately in #649.

Validation: this PR's head, 563cea409e12eb2494f67d4e20524a0d162d1c9f, passed GitHub's Build and Test workflow and was used to fast-forward #647 during consolidation. A fresh local full x race suite and staticcheck also pass. Module files and dependencies are unchanged.

@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This migration appears safe to merge.

Summary

Migrates tools, examples, mobileproxy, and smart from deprecated providers to NewDefaultRegistry, New[T], and RegisterBase.

  • Tools, examples, and mobileproxy build config URLs through typed registries.
  • SmartDialer searches build transports through typed registries.
  • The connectivity tool builds traced transports through registered base dialers.

Reviews (1) · Last reviewed commit: "refactor(x): migrate config URL consumer..." · Reviewed by Greptile

@fortuna
fortuna requested review from ohnorobo and removed request for jyyi1 October 29, 2026 21:42
@fortuna
fortuna removed this pull request from stack #653 October 29, 2026 22:37
@fortuna
fortuna merged commit 563cea4 into feat/smart-configurl-registry Oct 29, 2026
8 checks passed
@fortuna
fortuna deleted the refactor/configurl-registry-consumers branch October 29, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants