Repository navigation
refactor(x): migrate config URL consumers to registry - #652
Merged
fortuna merged 1 commit intoOct 29, 2026
Merged
Conversation
This was referenced Oct 23, 2026
fortuna
marked this pull request as ready for review
October 23, 2026 18:16
[Medium impact] This migration appears safe to merge. SummaryMigrates tools, examples,
Reviews (1) · Last reviewed commit: "refactor(x): migrate config URL consumer..." · Reviewed by Greptile |
angelodlfrtr
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged into #647 (
feat/smart-configurl-registry). SDK tools, examples, and existing SmartDialer/Mobileproxy construction now useNewDefaultRegistry,New[T], andRegisterBase.The combined #647 contains the registry API, deprecations, and these caller migrations, resolving the deprecated-API errors in CI. SmartDialer/Mobileproxy extension options remain in #649, stacked directly on #647.
The connectivity tool preserves its tracing dialer lifetime and per-operation tracing. This migration still uses local registries in SmartDialer; configurable shared registries are introduced separately in #649.
Validation: this PR's head,
563cea409e12eb2494f67d4e20524a0d162d1c9f, passed GitHub's Build and Test workflow and was used to fast-forward #647 during consolidation. A fresh local fullxrace suite and staticcheck also pass. Module files and dependencies are unchanged.