Open
Conversation
Member
|
feat: 새로운 기능 추가 다음부터는 이 형식에 맞춰서 커밋 제목 작성해주세요. 커밋은 되도록이면 자주하는 것이 좋습니다. |
Member
|
[2일차] {본인이름} 과제 제출합니다. 그리고 이 형식에 맞게 PR 제목 수정해주세요. |
Member
|
App 컴포넌트를 제외하고 props를 주고받는 컴포넌트 2개 이상 사용 해당 요구사항을 맞추지 않았습니다. 요구사항 꼼꼼히 확인해주세요.. |
Member
useEffect(() => {
if (text.current) text.current.textContent = coin;
}, [coin]);해당 부분은 useEffect를 쓰기 위해 억지로 사용한 느낌이 듭니다. <p ref={text} style={{fontWeight: 'bolder'}}>0</p>이부분을 <p style={{fontWeight: 'bolder'}}>{coin}</p>이렇게 사용하는게 훨씬 깔끔할 것 같네요. 이렇게 사용하는게 성능 및 안정성에도 이점이 있습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.