Build/test cleanup: drop duplicated test JVM args, refresh stale Javadoc#7587
Merged
Conversation
* build.gradle: drop duplicated test-task JVM args
tasks.named("test", Test) re-added six args that
tasks.withType(Test).configureEach already applies to every Test:
-Dtestfx.robot=glass, -Dtestfx.headless=true, -Dprism.order=sw,
--add-exports for javafx.graphics/com.sun.javafx.util and
javafx.base/com.sun.javafx.logging, and --add-opens for
javafx.graphics/com.sun.glass.ui. Each was landing on the test JVM
command line twice.
Kept --add-opens javafx.graphics/com.sun.javafx.application: withType
has --add-exports (not --add-opens) for that package, and TestFX's
@AfterEach cleanup uses setAccessible(true) on a private field of
ParametersImpl, which exports alone don't satisfy. Verified by running
pcgen.gui3.dialog.AboutDialogTest after the cleanup.
* PluginBuildTest: refresh stale class Javadoc
The class Javadoc still referenced the deleted Ant pluginbuild.xml.
Now describes what the test actually does today: every plugin source
file under code/src/java/plugin/<category>/ is packaged into the
matching <category>plugins.jar produced by code/gradle/plugins.gradle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tasks.named("test", Test)block — they are already applied to every Test by thetasks.withType(Test).configureEachblock (-Dtestfx.robot=glass,-Dtestfx.headless=true,-Dprism.order=sw,--add-exportsforjavafx.graphics/com.sun.javafx.utilandjavafx.base/com.sun.javafx.logging,--add-opens javafx.graphics/com.sun.glass.ui). Each was landing on the test JVM command line twice. Kept--add-opens javafx.graphics/com.sun.javafx.applicationbecausewithTypehas--add-exports(not--add-opens) for that package, and TestFX's@AfterEachcleanup usessetAccessible(true)deep reflection onParametersImpl.pluginbuild.xml. Updated to describe what the test actually does (everyplugin/<category>/source file is packaged into the matching<category>plugins.jar).Test plan
./gradlew help— build script parses./gradlew compileTestJava— clean compile./gradlew :test --tests pcgen.gui3.dialog.AboutDialogTest— TestFX test still passes (confirms the kept--add-opensis sufficient for ParametersImpl deep reflection)