Skip to content

Add market share to CX overview table - #475

Open
richjenks wants to merge 7 commits into
PRUNplanner:mainfrom
richjenks:material-cx-overview-market-share
Open

Add market share to CX overview table#475
richjenks wants to merge 7 commits into
PRUNplanner:mainfrom
richjenks:material-cx-overview-market-share

Conversation

@richjenks

Copy link
Copy Markdown
Contributor

Added market share percentages to the CX overview table in these places:

  1. Plan: using daily delta
  2. Empire: using daily delta
  3. ROI Overview: outputs × buildings × runs × 1.25*
  • COGC with 0 experts
image

Also fixed small annoyances I came across along the way:

  • Improved CX tooltip positioning, considering surrounding UI, horizontally (e.g. Plan) or vertically (e.g. Construction Cart) as appropriate. General text tooltips unchanged.
  • Hover any part of MaterialTile to show CX overview table, not just ticker text
  • Fixed broken HTML entities in translation files for Empire screen

@netlify

netlify Bot commented Jul 23, 2026

Copy link
Copy Markdown

👷 Deploy request for prunplanner-preview pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c56aa00

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 2 high

Alerts:
⚠ 2 issues (≤ 0 issues of at least minor severity)

Results:
2 new issues

Category Results
Security 2 high

View in Codacy

🟢 Metrics -4 duplication

Metric Results
Duplication -4

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@richjenks

Copy link
Copy Markdown
Contributor Author

False positive from codacy imo, I don't think this should prevent merging.

cx is the app's known exchangeTypesArray used to read from the app's known overviewData. No user input or opportunity for malicious manipulation.

Similar pattern already exists in a dozen places so making codacy happy is a fair bit of work with no apparent benefit (e.g. line 197 that predates this PR, useExchangeData.ts, planningStore.ts, usePlanetData.ts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant