Add market share to CX overview table - #475
Open
richjenks wants to merge 7 commits into
Open
Conversation
Material tiles default left, best in most places Specific instances overridden where sensisble, e.g. construction cart Tooltip config tweaked to allow more sensible positioning
👷 Deploy request for prunplanner-preview pending review.Visit the deploys page to approve it
|
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 2 high |
🟢 Metrics -4 duplication
Metric Results Duplication -4
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Contributor
Author
|
False positive from codacy imo, I don't think this should prevent merging.
Similar pattern already exists in a dozen places so making codacy happy is a fair bit of work with no apparent benefit (e.g. line 197 that predates this PR, useExchangeData.ts, planningStore.ts, usePlanetData.ts) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added market share percentages to the CX overview table in these places:
outputs × buildings × runs × 1.25*Also fixed small annoyances I came across along the way: