Fix crashes from unmapped UIDs and invalid DNS lookups#327
Open
kimjune01 wants to merge 2 commits into
Open
Conversation
Two crash fixes: 1. Issue PabloLec#186: Handle unmapped UIDs gracefully - Wrap execSync("id -nu") in try-catch - Fall back to numeric UID when user lookup fails - Prevents crash in containerized environments (NixOS, etc.) 2. Issue PabloLec#177: Handle DNS reverse lookup errors - Wrap reverse() in try-catch block - DNS can throw synchronously on invalid addresses (EINVAL) - Prevents intermittent crashes during refresh Both fixes are defensive: continue operation with degraded data (UID instead of username, IP instead of hostname) rather than crash the entire application.
The test script is useful for local verification but shouldn't be committed — it's CJS in a TypeScript project and not wired into the test runner.
kimjune01
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execSync('id -nu')in try/catch to handle unmapped UIDs in containerized environments (NixOS, Docker). Falls back to showing the numeric UID instead of crashing.dns.reverse()in try/catch to handle synchronous throws on invalid/malformed IP addresses. Keeps the original IP address on failure.Fixes #186
Test plan
npx tsc --noEmitpasses with zero errors/procwith specific container state (unmapped UIDs) - verified by code review