Skip to content

simplify Mio example from chapter 4 somewhat #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtepe wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −4
Open

simplify Mio example from chapter 4 somewhat #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ch04/b-epoll-mio/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,9 @@ fn handle_events(events: &[Event], streams: &mut [TcpStream], handled: &mut Hash
Ok(n) if n == 0 => {
// FIX #4
// `insert` returns false if the value already existed in the set.
if !handled.insert(index) {
break;
if handled.insert(index) {
handled_events += 1;
}
handled_events += 1;
break;
}
Ok(n) => {
Expand Down Expand Up @@ -147,7 +146,7 @@ fn main() -> Result<()> {
// ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
// To make minimal changes to the existing code we create a Vec<Event> from mio's
// Events collection
let events: Vec<Event> = events.into_iter().map(|e| e.clone()).collect();
let events: Vec<Event> = events.into_iter().cloned().collect();
// ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

// ------------------------------------------------------⌄ FIX #4 (new signature)
Expand Down