Skip to content

fix(ci): 移除指定 Flutter 版本号 - #38

Merged
xiaocaoooo merged 3 commits into
mainfrom
fix/ci-remove-flutter-version
Jun 20, 2026
Merged

fix(ci): 移除指定 Flutter 版本号#38
xiaocaoooo merged 3 commits into
mainfrom
fix/ci-remove-flutter-version

Conversation

@xiaocaoooo

@xiaocaoooo xiaocaoooo commented Jun 20, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated CI workflows to use Flutter’s stable channel instead of a pinned Flutter version.
    • Adjusted Windows build settings to reduce experimental coroutine deprecation warning noise.
  • Bug Fixes
    • Fixed sticker layer drag-and-drop reordering so layers land in the correct target position.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fe28b14c-7d4a-4fa9-aeaa-21091e05291f

📥 Commits

Reviewing files that changed from the base of the PR and between 7b7464b and b571114.

📒 Files selected for processing (1)
  • windows/CMakeLists.txt
✅ Files skipped from review due to trivial changes (1)
  • windows/CMakeLists.txt

📝 Walkthrough

Walkthrough

Three independent changes across CI workflows, sticker layer reordering, and Windows build configuration. CI workflows drop the pinned flutter-version: "3.38.1", keeping only channel: "stable". The sticker page reorder flow switches from onReorder to onReorderItem callback and simplifies _reorderLayer index logic. Windows build suppresses experimental coroutine deprecation warnings.

Changes

CI Flutter Version Unpinning

Layer / File(s) Summary
Remove pinned Flutter version from release workflow
.github/workflows/release.yml
The Setup Flutter step drops flutter-version: "3.38.1", retaining only channel: "stable".

Layer Drag-Reorder Fix

Layer / File(s) Summary
Fix reorder callback and index logic
lib/pages/sticker/sticker_page_sections.dart, lib/pages/sticker/sticker_page_layers.dart
ReorderableListView.builder wires onReorderItem: _reorderLayer instead of onReorder; _reorderLayer replaces adjusted-index calculation with an early return when oldIndex == newIndex and inserts directly at newIndex.

Windows Build Configuration

Layer / File(s) Summary
Suppress coroutine deprecation warnings
windows/CMakeLists.txt
Adds _SILENCE_EXPERIMENTAL_COROUTINE_DEPRECATION_WARNINGS global compile definition.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🐇 Hop, hop, the version pin is gone,
No 3.38.1 to hold us along!
The layers slide smoothly to their place,
onReorderItem runs the race.
Old index equals new? We simply skip—
A tidier list on every trip! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims to remove the Flutter version number, but the PR also includes changes to layer reordering logic and build configuration that are unrelated to CI/Flutter versioning. Update the title to be more comprehensive, such as 'fix(ci,logic,build): Remove Flutter version pin and update layer reorder logic' or split into multiple focused PRs.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-remove-flutter-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xiaocaoooo
xiaocaoooo merged commit 29b2806 into main Jun 20, 2026
11 checks passed
@xiaocaoooo
xiaocaoooo deleted the fix/ci-remove-flutter-version branch June 20, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant