Conversation
Contributor
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | 0.55 % | 4.141e+03 | 4.163e+03 | 22.77 | 32.27 | 29.75 |
test_proximal_jac_w7x_with_eq_update | 0.16 % | 6.836e+03 | 6.847e+03 | 11.16 | 153.86 | 151.21 |
test_proximal_freeb_jac | -0.18 % | 1.342e+04 | 1.340e+04 | -23.57 | 80.22 | 80.92 |
test_proximal_freeb_jac_blocked | -0.69 % | 7.792e+03 | 7.739e+03 | -53.88 | 70.69 | 72.71 |
test_proximal_freeb_jac_batched | 0.70 % | 7.710e+03 | 7.764e+03 | 53.75 | 70.78 | 71.50 |
test_proximal_jac_ripple | 1.83 % | 3.550e+03 | 3.615e+03 | 64.99 | 55.55 | 55.34 |
test_proximal_jac_ripple_bounce1d | -0.10 % | 3.834e+03 | 3.830e+03 | -3.80 | 73.16 | 68.12 |
test_eq_solve | 1.04 % | 2.080e+03 | 2.102e+03 | 21.66 | 88.54 | 88.53 |For the memory plots, go to the summary of |
Collaborator
Author
|
@f0uriest what do you think about bumping the minimum jax version to 0.6.2? It is almost a year old now (June 17, 2025). |
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the dependencies manually before the new release. The Dependabot issue persists.
Question:
Looks like
jax.tree_util.tree_broadcastwas added with jax 0.6.2. Should I try to copy their implementation tobackend.pyor should I just update min jax version? Affect jax version are 0.5.0, 0.5.3 and 0.6.1 (we don't allow others anyway)