-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add PokemonStatPast #1382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add PokemonStatPast #1382
Conversation
|
Upon further reflection, I think even though the stats are different and EV yields didn’t exist in generation 1, it may be best to have all information in |
…ed data for gen 1 pokemon" This reverts commit 8e670c0.
|
No changes were changed between generation 1 and 2 other than the splitting of the special stat, so instead of a separate field for original stats I just added the special stat as an entry in the past stats field. Should be all settled now! |
|
ok, thanks again. I'll take some time to understand what's going on! |
|
I edited the initial PR description to make it clearer since I made a big change after the fact - as always if you have questions/suggestions let me know! |
This PR addresses issue #1325 and adds a new model:
PokemonStatPastto store changes to base stats and EV yields over generations. The new model came with a new CSV file:pokemon_stats_past.csv.In addition to these additions, the following changes were made:
specialstat to track generation 1 stat spread.Information retrieved from the different pages linked in https://bulbapedia.bulbagarden.net/wiki/List_of_Pok%C3%A9mon_by_effort_value_yield_in_Generation_IX and https://bulbapedia.bulbagarden.net/wiki/Base_stats#Changes.
Edited to reflect current state of PR.