Repository navigation
Update ability changelog prose & trace in ability prose - #1699
Conversation
|
Not really sure what this static check fail is. Can someone inform me? Edit: it was trailing white spaces. |
|
Hey @notblisy thanks for the contribution. To me it's fine, the only thing is that those English entries differ from the other languages. I saw that in the file we have French and German and it's a bit of a mix between the standard you are bringing in and the past one. |
As we discussed in #1423 the new formatting wouldn't break anything, so I think it's fine to have the old format there for other languages until someone else updates them. I don't speak any languages other than english fluently so we'd have to wait until someone can do the translations. After this is merged, I plan to go back do a more thorough dive into the abilities on a per gen basis because I suspect some stuff is missing or worded strangely. I just wanted to get the updated info in. Maybe @jemarq04 would like to weigh in? |
|
Alright! Then we can merge 👍 thanks! |
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
Ability effect text on the Ability page and in the Pokemon page ability tooltips now resolves from effect_changes, so each game shows the effect as it was then (e.g. Sturdy before Black/White, Trace in Gen 3 vs Gen 4), matching how move past_values are applied. Uses the full per-version text added upstream in PokeAPI/pokeapi#1699.
3 participants
Change description
As discussed in #1423, ability changelog prose on live is inconsistent to how all other past values are presented.
Currently, any time an ability has a change, the change prose only shows what is different from the live, and not the entire ability. I have updated all the english text to be the entire account of what that ability does in each version group. This will allow this csv to be used the same as past_stats, for example.
In addition, while doing this, I noticed ability prose says trace cannot copy wonderguard, which is not true.
Most of my text is rewording of whatever ability_prose.csv has, but removing or adding relevant features of the abilities. Sometimes I replaced the entire thing with a smogon description, or my own, because the veekun phrasing can be quite verbose.
Lastly, I tried to remove any moves or abilities mentioned in an ability text that would reference things not in a given generation. IE, white smoke mentions heart swap in RS's entry, which did not exist then.
AI coding assistance disclosure
No AI was used while making this PR.
Contributor check list