Skip to content

Fix Windows hook dispatch via explicit bash invocation #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ianliuy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Windows hook dispatch via explicit bash invocation #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude-plugin/marketplace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"name": "humanize",
"source": "./",
"description": "Humanize - An iterative development plugin that uses Codex to review Claude's work. Creates a feedback loop where Claude implements plans and Codex independently reviews progress, ensuring quality through continuous refinement.",
"version": "1.15.4"
"version": "1.15.5"
}
]
}
2 changes: 1 addition & 1 deletion .claude-plugin/plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "humanize",
"description": "Humanize - An iterative development plugin that uses Codex to review Claude's work. Creates a feedback loop where Claude implements plans and Codex independently reviews progress, ensuring quality through continuous refinement.",
"version": "1.15.4",
"version": "1.15.5",
"author": {
"name": "PolyArch"
},
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Humanize

**Current Version: 1.15.4**
**Current Version: 1.15.5**

> Derived from the [GAAC (GitHub-as-a-Context)](https://github.com/SihaoLiu/gaac) project.

Expand Down
16 changes: 8 additions & 8 deletions hooks/hooks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"hooks": [
{
"type": "command",
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/loop-plan-file-validator.sh"
"command": "bash \"${CLAUDE_PLUGIN_ROOT}/hooks/loop-plan-file-validator.sh\""
}
]
}
Expand All @@ -17,7 +17,7 @@
"hooks": [
{
"type": "command",
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/loop-write-validator.sh"
"command": "bash \"${CLAUDE_PLUGIN_ROOT}/hooks/loop-write-validator.sh\""
}
]
},
Expand All @@ -26,7 +26,7 @@
"hooks": [
{
"type": "command",
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/loop-edit-validator.sh"
"command": "bash \"${CLAUDE_PLUGIN_ROOT}/hooks/loop-edit-validator.sh\""
}
]
},
Expand All @@ -35,7 +35,7 @@
"hooks": [
{
"type": "command",
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/loop-read-validator.sh"
"command": "bash \"${CLAUDE_PLUGIN_ROOT}/hooks/loop-read-validator.sh\""
}
]
},
Expand All @@ -44,7 +44,7 @@
"hooks": [
{
"type": "command",
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/loop-bash-validator.sh"
"command": "bash \"${CLAUDE_PLUGIN_ROOT}/hooks/loop-bash-validator.sh\""
}
]
}
Expand All @@ -55,7 +55,7 @@
"hooks": [
{
"type": "command",
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/loop-post-bash-hook.sh"
"command": "bash \"${CLAUDE_PLUGIN_ROOT}/hooks/loop-post-bash-hook.sh\""
}
]
}
Expand All @@ -65,12 +65,12 @@
"hooks": [
{
"type": "command",
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/loop-codex-stop-hook.sh",
"command": "bash \"${CLAUDE_PLUGIN_ROOT}/hooks/loop-codex-stop-hook.sh\"",
"timeout": 7200
},
{
"type": "command",
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/pr-loop-stop-hook.sh",
"command": "bash \"${CLAUDE_PLUGIN_ROOT}/hooks/pr-loop-stop-hook.sh\"",
"timeout": 7200
}
]
Expand Down
4 changes: 3 additions & 1 deletion hooks/lib/loop-common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,9 @@ is_cancel_authorized() {
# Check if a path is inside .humanize/rlcr directory
is_in_humanize_loop_dir() {
local path="$1"
echo "$path" | grep -q '\.humanize/rlcr/'
# Normalize backslashes to forward slashes so Windows paths (C:\...\.humanize\rlcr\...)
# match the POSIX pattern the rest of the hook tree expects.
echo "${path//\\//}" | grep -q '\.humanize/rlcr/'
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve round-number enforcement for Windows paths

This change makes is_in_humanize_loop_dir return true for backslash-separated Windows paths, but the downstream Write/Edit validators still parse loop-relative filenames with forward-slash-only sed patterns (hooks/loop-write-validator.sh:218-223 and hooks/loop-edit-validator.sh:157-160). For inputs like C:\...\.humanize\rlcr\...\round-99-summary.md, filename extraction becomes empty and both validators fall through to exit 0, allowing wrong-round summary writes/edits that should be blocked. I verified the behavior change by executing the parent commit and this commit with the same Windows-style path: parent returns exit 2 (blocked), this commit returns exit 0 (allowed).

Useful? React with 👍 / 👎.

}

# ========================================
Expand Down
Loading