fix(codex): use renamed hooks feature#134
Open
VitalyAnkh wants to merge 2 commits intoPolyArch:devfrom
Open
Conversation
90ad053 to
ccdd685
Compare
Author
|
CI is still blocked at GitHub's fork-workflow approval gate ( Once an upstream admin approves the workflow run, I can inspect and fix any real CI failures. Reference commit: openai/codex@0d9a5d2 |
Author
|
CI failure on Fix: switch those checks to here-strings ( Local verification after the fix:
Reference commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the Codex install path for the native hook feature rename.
codex_hooksis now treated as the legacy name. If it appears inconfig.toml, the installer fails with an upgrade hint.codex_hooks, the installer stops and tells the user to upgrade Codex.hooks.hooksname.Reference:
codex_hooksashooks.Verification:
bash -n scripts/install-codex-hooks.sh scripts/bitlesson-select.sh hooks/loop-codex-stop-hook.sh tests/test-codex-hook-install.sh tests/test-disable-nested-codex-hooks.sh tests/test-bitlesson-select-routing.sh tests/test-monitor-runtime.sh tests/run-all-tests.shbash tests/test-codex-hook-install.shbash tests/test-disable-nested-codex-hooks.shbash tests/test-bitlesson-select-routing.shXDG_CONFIG_HOME=$(mktemp -d) HUMANIZE_TEST_JOBS=4 ./tests/run-all-tests.sh