Skip to content

fix(codex): use renamed hooks feature#134

Open
VitalyAnkh wants to merge 2 commits intoPolyArch:devfrom
VitalyAnkh:fix/codex-hooks-feature-rename
Open

fix(codex): use renamed hooks feature#134
VitalyAnkh wants to merge 2 commits intoPolyArch:devfrom
VitalyAnkh:fix/codex-hooks-feature-rename

Conversation

@VitalyAnkh
Copy link
Copy Markdown

@VitalyAnkh VitalyAnkh commented May 2, 2026

This updates the Codex install path for the native hook feature rename.

  • codex_hooks is now treated as the legacy name. If it appears in config.toml, the installer fails with an upgrade hint.
  • If the installed Codex CLI only exposes codex_hooks, the installer stops and tells the user to upgrade Codex.
  • Nested Codex calls now disable hooks.
  • Docs and tests now use the new hooks name.
  • The full test runner keeps the signal-heavy monitor runtime suite serial so the parallel suite stays stable.

Reference:

Verification:

  • bash -n scripts/install-codex-hooks.sh scripts/bitlesson-select.sh hooks/loop-codex-stop-hook.sh tests/test-codex-hook-install.sh tests/test-disable-nested-codex-hooks.sh tests/test-bitlesson-select-routing.sh tests/test-monitor-runtime.sh tests/run-all-tests.sh
  • bash tests/test-codex-hook-install.sh
  • bash tests/test-disable-nested-codex-hooks.sh
  • bash tests/test-bitlesson-select-routing.sh
  • XDG_CONFIG_HOME=$(mktemp -d) HUMANIZE_TEST_JOBS=4 ./tests/run-all-tests.sh

@VitalyAnkh VitalyAnkh force-pushed the fix/codex-hooks-feature-rename branch from 90ad053 to ccdd685 Compare May 2, 2026 23:21
@VitalyAnkh
Copy link
Copy Markdown
Author

CI is still blocked at GitHub's fork-workflow approval gate (action_required). I cannot approve the run from this account because upstream permissions are read-only.

Once an upstream admin approves the workflow run, I can inspect and fix any real CI failures.

Reference commit: openai/codex@0d9a5d2

@VitalyAnkh
Copy link
Copy Markdown
Author

CI failure on run-all-tests was due to tests/test-templates-comprehensive.sh using echo "$result" | grep -q ... on a large template render under set -o pipefail, which can trip Broken pipe on Ubuntu runners when grep -q exits early.

Fix: switch those checks to here-strings (grep -q ... <<<"$result") so the test no longer depends on a SIGPIPE-prone pipeline.

Local verification after the fix:

  • bash tests/test-templates-comprehensive.sh
  • XDG_CONFIG_HOME=$(mktemp -d) HUMANIZE_TEST_JOBS=4 ./tests/run-all-tests.sh

Reference commit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant