-
Notifications
You must be signed in to change notification settings - Fork 64
GraphQL improvements for v4 #2416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eing mutated. If we allow that to happen, reinserting it doesn't fix anything as the graph might already have been re-cached as well and state is inconsistent.
…cture and refactor the validation logic (compiles but does not work yet)
…gets cleaned up again!
d510502 to
b669122
Compare
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 680901d | Previous: 102a9fe | Ratio |
|---|---|---|---|
local_triangle_count/local_triangle_count |
1549513 ns/iter (± 125874) |
706696 ns/iter (± 8298) |
2.19 |
lotr_graph/num_edges |
4 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
79 ns/iter (± 0) |
1 ns/iter (± 0) |
79 |
lotr_graph_materialise/materialize |
3137711 ns/iter (± 8991) |
1468616 ns/iter (± 9419) |
2.14 |
lotr_graph_window_100/num_edges |
27 ns/iter (± 0) |
8 ns/iter (± 0) |
3.38 |
lotr_graph_window_100/num_nodes |
90 ns/iter (± 0) |
5 ns/iter (± 0) |
18 |
lotr_graph_window_100_materialise/materialize |
3530994 ns/iter (± 5857) |
1616091 ns/iter (± 5804) |
2.18 |
lotr_graph_window_10/iterate nodes |
32000 ns/iter (± 60) |
13145 ns/iter (± 247) |
2.43 |
lotr_graph_window_10/iterate edges |
105645 ns/iter (± 229) |
49732 ns/iter (± 628) |
2.12 |
lotr_graph_subgraph_10pc/has_edge_existing |
474 ns/iter (± 5) |
94 ns/iter (± 2) |
5.04 |
lotr_graph_subgraph_10pc/has_node_existing |
226 ns/iter (± 2) |
35 ns/iter (± 0) |
6.46 |
lotr_graph_subgraph_10pc/iterate nodes |
3760 ns/iter (± 7) |
1145 ns/iter (± 3) |
3.28 |
lotr_graph_subgraph_10pc_windowed/iterate nodes |
3849 ns/iter (± 8) |
1763 ns/iter (± 30) |
2.18 |
lotr_graph_window_50_layered/num_nodes |
100417 ns/iter (± 2676) |
23723 ns/iter (± 2295) |
4.23 |
lotr_graph_window_50_layered/has_node_existing |
1581 ns/iter (± 224) |
140 ns/iter (± 15) |
11.29 |
lotr_graph_window_50_layered/max_id |
110826 ns/iter (± 3173) |
30054 ns/iter (± 341) |
3.69 |
lotr_graph_window_50_layered/max_degree |
2125979 ns/iter (± 36938) |
301176 ns/iter (± 12201) |
7.06 |
lotr_graph_window_50_layered/iterate nodes |
237328 ns/iter (± 563) |
22036 ns/iter (± 207) |
10.77 |
lotr_graph_window_50_layered/iterate edges |
218695 ns/iter (± 498) |
94360 ns/iter (± 2143) |
2.32 |
lotr_graph_window_50_layered/max_neighbour_degree |
3610312 ns/iter (± 36936) |
405979 ns/iter (± 4756) |
8.89 |
lotr_graph_window_50_layered_materialise/materialize |
7994150 ns/iter (± 144807) |
3369999 ns/iter (± 23217) |
2.37 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
579117 ns/iter (± 6275) |
213894 ns/iter (± 3659) |
2.71 |
lotr_graph_persistent_window_50_layered/num_nodes |
147977 ns/iter (± 4242) |
33955 ns/iter (± 907) |
4.36 |
lotr_graph_persistent_window_50_layered/has_node_existing |
1634 ns/iter (± 451) |
179 ns/iter (± 93) |
9.13 |
lotr_graph_persistent_window_50_layered/max_id |
151678 ns/iter (± 4505) |
42737 ns/iter (± 2220) |
3.55 |
lotr_graph_persistent_window_50_layered/max_degree |
3008263 ns/iter (± 43880) |
466749 ns/iter (± 14768) |
6.45 |
lotr_graph_persistent_window_50_layered/iterate nodes |
324909 ns/iter (± 718) |
41506 ns/iter (± 354) |
7.83 |
lotr_graph_persistent_window_50_layered/max_neighbour_degree |
4834904 ns/iter (± 34175) |
525340 ns/iter (± 4113) |
9.20 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
13977171 ns/iter (± 18993) |
5151712 ns/iter (± 94249) |
2.71 |
lotr_graph/proto_decode |
20129430 ns/iter (± 107772) |
1911611 ns/iter (± 25778) |
10.53 |
lotr_graph/proto_encode |
9228254 ns/iter (± 110930) |
1153254 ns/iter (± 20173) |
8.00 |
This comment was automatically generated by workflow using github-action-benchmark.
5addf9e to
b79c7e5
Compare
7031768 to
11b4b62
Compare
266997e to
248953e
Compare
48282b1 to
40a7d97
Compare
adb1509 to
9b6fc47
Compare
a164c48 to
40d1ab6
Compare
ac09032 to
680901d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
fixes #2377 (reenables the tests and fixes serialisation)
fixes #2384
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Are there any further changes required?