feat: add configurable completion sounds #236
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional notification sounds that play when agent tasks complete. Users can choose from three sounds (guitar solo, "I'm ready", cute noise) or disable sounds entirely (default). - Add completion sound setting to settings store - Add Notifications section to Settings page with sound picker and test button - Create event emitter pattern for session events (clean separation of concerns) - Create useSessionEventHandlers hook for handling side effects at app level - Import sounds as ES modules for proper Vite asset handling 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
joshsny
approved these changes
Dec 12, 2025
Contributor
joshsny
left a comment
joshsny
left a comment
There was a problem hiding this comment.
massive shareholder value unlocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation
sessionEvents.ts) for clean separation between session state and side effectsuseSessionEventHandlershook handles audio playback at app level with proper cleanupTest plan
🤖 Generated with Claude Code