fix: handle cross-panel tab drops on tab bar and other tabs #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 13, 2025
Merged
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
jonathanlab
changed the base branch from
12-13-feat_add_file_icons
to
graphite-base/256
jonathanlab
force-pushed
the
12-13-fix_handle_cross-panel_tab_drops_on_tab_bar_and_other_tabs
branch
from
ce653e2 to
87c3b95
Compare
jonathanlab
force-pushed
the
graphite-base/256
branch
from
d8dde65 to
9e71f7f
Compare
When dragging a tab from one pane to another via the tab bar (instead of the drop zones), the handler only processed drops with type "panel". Drops on "tab-bar" and cross-panel "tab" targets were ignored, causing the source pane to persist empty while only the visual tab moved.
jonathanlab
force-pushed
the
12-13-fix_handle_cross-panel_tab_drops_on_tab_bar_and_other_tabs
branch
from
87c3b95 to
a7f66d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dragging a tab from one pane to another via the tab bar (instead of
the drop zones), the handler only processed drops with type "panel".
Drops on "tab-bar" and cross-panel "tab" targets were ignored, causing
the source pane to persist empty while only the visual tab moved.