Skip to content

Fix pp 3.5.4 related tests - #489

Merged
mgovers merged 3 commits into
PowerGridModel:mainfrom
furqan463:fix_pp_gen
Sep 10, 2026
Merged

Fix pp 3.5.4 related tests#489
mgovers merged 3 commits into
PowerGridModel:mainfrom
furqan463:fix_pp_gen

Conversation

@furqan463

@furqan463 furqan463 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Relates Issue #488

Changes proposed in this PR include

Fixes failed tests after upgrading to pandapower=3.5.4. adds fixes missed in #370. pandapower attribute __format_version__ is being kept at 3.1.0 for backward compatibility, though it was updated to 3.3.0 in padnapower=3.3.0 but later reverted. That's the only change required to fix json conversion errors.

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
@furqan463

Copy link
Copy Markdown
Contributor Author

@nitbharambe @figueroa1395 all tests now clear with these minimal changes.
However, it's not fully aligned with pandapower=3.5.4, as for 3-ph output of gen, phase-wise powers are introduced in e2nIEE/pandapower#3010. In current setup the pp output json file and pandapower_converter both have only p_mw and q_mvar as output for res_gen_3ph, therefore all tests are clear.
However, to fully align with pandapower=3.5.4 phase-wise outputs need to be generated/ converted for res_gen_3ph.
I'll take that up next.

@furqan463

Copy link
Copy Markdown
Contributor Author

I'll take that up next.

or we remove fix to #488 from this PR, and move this task to another PR.

@furqan463

Copy link
Copy Markdown
Contributor Author

move this task to another PR.

I'm working on this fix on another branch, will create PR after this is merged.

@furqan463

Copy link
Copy Markdown
Contributor Author

@figueroa1395 this should fix tests for #495
We can remove uv.lock from this PR as well.

@figueroa1395

Copy link
Copy Markdown
Member

@figueroa1395 this should fix tests for #495 We can remove uv.lock from this PR as well.

@furqan463 Thanks for the heads up. We'll get back to you as soon as we can.

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
@figueroa1395 figueroa1395 added the bug Something isn't working label Sep 9, 2026

@mgovers mgovers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @furqan463,

Sorry for the delay.

LGTM

Great decision to offload the 3ph output to #496 .

@mgovers
mgovers added this pull request to the merge queue Sep 10, 2026
Merged via the queue into PowerGridModel:main with commit 079e8a9 Sep 10, 2026
29 of 30 checks passed
@furqan463
furqan463 deleted the fix_pp_gen branch September 10, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants