fix: batch Vision GUID number columns - #492
Open
be-student wants to merge 3 commits into
Open
Conversation
Member
|
Hi @be-student , thank you for creating this PR! We will review the PR. If necessary, we may rebase it to a different branch. |
appleweiping
reviewed
Sep 7, 2026
| number_values = guid_values.apply(self._uuid_cvtr.query) | ||
| if new_column_name in first_level: | ||
| number_column_pos = first_level.tolist().index(new_column_name) | ||
| data.iloc[:, number_column_pos] = number_values |
There was a problem hiding this comment.
iloc assignment keeps the existing column dtype, while the previous column assignment replaced it. With an existing object typed Number column, the generated integer values remain object typed, which can affect downstream numeric handling. I reproduced this with pandas 2.3.3. Could this use data.isetitem(number_column_pos, number_values) and add a regression assertion for the resulting dtype? This still updates by position for MultiIndex columns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #468.
Builds all generated Number columns in one concat operation instead of repeatedly inserting them. This removes pandas fragmentation warnings and preserves each GUID/Number pair's order, including MultiIndex inputs and existing Number columns.
Validation: 1,444 tests pass; focused tests, Ruff, MyPy, REUSE, and full pre-commit pass.