Fix: Restore Voltage Regulator warning regarding support for NR only - #1573
Merged
Conversation
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
furqan463
changed the title
furqan463
changed the title
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
mgovers
approved these changes
Sep 7, 2026
mgovers
added
bug
mgovers
enabled auto-merge
September 7, 2026 07:29
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 7, 2026
Member
|
macos-26-intel was flaky. not an issue with this PR |
Merged
via the queue into
PowerGridModel:main
with commit Sep 7, 2026
e50f161
32 of 34 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #1452 a warning was unintentionally removed and the comment #1452 (comment) remained unresolved.
In my opinion it should be a warning, but at-least it should be a note to make it more visible.