Merge links into nodes: fix pseudo branch registration order - #1581
Merged
mgovers merged 1 commit intoSep 9, 2026
Merged
Conversation
nitbharambe
reviewed
Sep 9, 2026
…nch3) but before transformers so trafos pointed at wrong object Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
force-pushed
the
pgm/test/dual-code-path
branch
from
September 9, 2026 09:45
4535b1e to
3e37e4e
Compare
nitbharambe
reviewed
Sep 9, 2026
nitbharambe
approved these changes
Sep 9, 2026
mgovers
merged commit Sep 9, 2026
9c4c7e3
into
feature/link-registration-dual-code-path
29 of 30 checks passed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the backwards-compatible code path, links are registered as pseudo-branches, similar to how three-winding transformers are registered as pseudo-branches. However, all pseudo-branches need to be registered strictly after all "regular" branches are registered. This was a bug in #1550