test(markets): freeze error discriminants 443, 517-528, 660-674 - #1021
Merged
greatest0fallt1me merged 1 commit intoJul 26, 2026
Merged
Conversation
Add stability tests for 17 previously-uncovered error codes: market_extension_errors: AdminActionTimelocked(443), ForceResolveReplayed(517), ForceResolveReasonEmpty(518), NoPendingFeeCommit(519), FeeRevealTooEarly(520), FeePreimageMismatch(521), DisputeStakeCapExceeded(522), InsufficientStorageRentBudget(523), ExtensionCapExceeded(524), UpgradeChainMismatch(525), OracleQuoteOutlier(527), MaxParticipantsReached(528) overflow_cap_errors: IdempotentBatchAlreadyApplied(660), ReasonTableFull(670), Overflow(672), MaxBetCapExceeded(673), InvalidCap(674) Refs Predictify-org#860
|
@Vicistar-V Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
greatest0fallt1me
merged commit Jul 26, 2026
d6d6fcd
into
Predictify-org:master
0 of 2 checks passed
Contributor
|
Merged via direct push to master (admin) |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds stability tests for 17 previously-uncovered error code discriminants to
contracts/predictify-hybrid/tests/err_stability.rs.New test:
market_extension_errors(443, 517-528)AdminActionTimelocked(443)ForceResolveReplayed(517)ForceResolveReasonEmpty(518)NoPendingFeeCommit(519)FeeRevealTooEarly(520)FeePreimageMismatch(521)DisputeStakeCapExceeded(522)InsufficientStorageRentBudget(523)ExtensionCapExceeded(524)UpgradeChainMismatch(525)OracleQuoteOutlier(527)MaxParticipantsReached(528)New test:
overflow_cap_errors(660-674)IdempotentBatchAlreadyApplied(660)ReasonTableFull(670)Overflow(672)MaxBetCapExceeded(673)InvalidCap(674)Motivation
These error codes were added to
err.rsbut never frozen in the stability suite, meaning accidental reordering or deletion would go undetected by CI.Test Plan
cargo test --test err_stabilityCloses #860