Skip to content

Bump deps - #33

Merged
binaryoverload merged 5 commits into
masterfrom
fix/deps-update
Nov 11, 2026
Merged

binaryoverload merged 5 commits into
masterfrom
fix/deps-update

Conversation

@jonbarrow

@jonbarrow jonbarrow commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Resolves #XXX

Changes:

Bumps all the deps that had issues using npm audit fix, so it's clean now. This also bumps ts-proto to version 2.18.4 (latest)

The old version of ts-proto failed to build #32 in CI. That's my fault for not doing that locally, I figured that since CI built/ran it find in the PR and that it was all green, then the publishing would work too. It failed with the following errors:

> @pretendonetwork/grpc@2.6.3 generate
> buf generate && tsc
typescript/friends/v2/get_user_friend_pids_multi_rpc.ts:22:12 - error TS1268: An index signature parameter type must be 'string', 'number', 'symbol', or a template literal type.
22   data: { [key: bigint]: FriendPIDList };
              ~~~
typescript/friends/v2/get_user_friend_pids_multi_rpc.ts:183:74 - error TS2322: Type 'unknown' is not assignable to type 'FriendPIDList | undefined'.
183       GetUserFriendPIDsMultiResponse_DataEntry.encode({ key: key as any, value }, writer.uint32(10).fork()).join();
                                                                             ~~~~~
  typescript/friends/v2/get_user_friend_pids_multi_rpc.ts:27:3
    27   value: FriendPIDList | undefined;
         ~~~~~
    The expected type comes from property 'value' which is declared here on type 'GetUserFriendPIDsMultiResponse_DataEntry'
typescript/friends/v2/get_user_friend_pids_multi_rpc.ts:202:26 - error TS2538: Type 'bigint' cannot be used as an index type.
202             message.data[entry1.key] = entry1.value;
                             ~~~~~~~~~~
typescript/friends/v2/get_user_friend_pids_multi_rpc.ts:218:49 - error TS1268: An index signature parameter type must be 'string', 'number', 'symbol', or a template literal type.
218         ? Object.entries(object.data).reduce<{ [key: bigint]: FriendPIDList }>((acc, [key, value]) => {
                                                    ~~~
typescript/friends/v2/get_user_friend_pids_multi_rpc.ts:219:11 - error TS7053: Element implicitly has an 'any' type because expression of type 'number' can't be used to index type '{}'.
  No index signature with a parameter of type 'number' was found on type '{}'.
219           acc[globalThis.Number(key)] = FriendPIDList.fromJSON(value);
              ~~~~~~~~~~~~~~~~~~~~~~~~~~~
typescript/friends/v2/get_user_friend_pids_multi_rpc.ts:233:46 - error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'FriendPIDList'.
233           obj.data[k] = FriendPIDList.toJSON(v);
                                                 ~
typescript/friends/v2/get_user_friend_pids_multi_rpc.ts:245:64 - error TS1268: An index signature parameter type must be 'string', 'number', 'symbol', or a template literal type.
245     message.data = Object.entries(object.data ?? {}).reduce<{ [key: bigint]: FriendPIDList }>((acc, [key, value]) => {
                                                                   ~~~
typescript/friends/v2/get_user_friend_pids_multi_rpc.ts:247:9 - error TS7053: Element implicitly has an 'any' type because expression of type 'number' can't be used to index type '{}'.
  No index signature with a parameter of type 'number' was found on type '{}'.
247         acc[globalThis.Number(key)] = FriendPIDList.fromPartial(value);
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~
typescript/friends/v2/get_user_friend_pids_multi_rpc.ts:247:65 - error TS2345: Argument of type '{} | null' is not assignable to parameter of type '{ pids?: bigint[] | undefined; }'.
  Type 'null' is not assignable to type '{ pids?: bigint[] | undefined; }'.
247         acc[globalThis.Number(key)] = FriendPIDList.fromPartial(value);
                                                                    ~~~~~
Found 9 errors in the same file, starting at: typescript/friends/v2/get_user_friend_pids_multi_rpc.ts:22

Bumping the version fixed this though

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow Validate Pull Request / check_buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedNov 11, 2026, 9:07 PM

@binaryoverload
binaryoverload merged commit 19cbfb8 into master Nov 11, 2026
4 checks passed
@binaryoverload
binaryoverload deleted the fix/deps-update branch November 11, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants