[codex] Truncate inference rank logs with tee#2817
Draft
samsja wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the startup
rm -f logs/inference/*.logcleanup with writer-side truncation for rank-specific inference logs.Why
The node-level inference log already matches trainer/orchestrator behavior: it gets a startup line through truncating
tee, then appends server output during the same run. The auxiliarynode_*_rank*.logfiles did not have that initial truncating write and only usedtee -a, so they could retain content when reusing an output directory.Impact
node_*.logheader-plus-append behavior.teefornode_*_rank*.logoutputs.Validation
git diff --check -- src/prime_rl/templates/_launch_rank.sh.j2 src/prime_rl/templates/inference.sbatch.j2 src/prime_rl/templates/multi_node_rl.sbatch.j2jinja2.Environment(...).get_template(...)