[ENG-4231] Add CLI support for verifiers v1 env configs#764
Open
eexwhyzee wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes how training/eval environment payloads are validated and serialized before run creation; mistakes could reject valid configs or send wrong API shapes, but scope is CLI config parsing with new tests covering v1 paths.
Overview
Adds verifiers v1 environment blocks to
prime trainTOML parsing and API payloads while keeping legacy[[env]].idconfigs working.Training and eval
[[env]]/[[eval.env]]entries can usetaskset+harness(and related v1 fields likegroup_size,ratio, pool/timeouts, token caps) without a top-levelid. Config validation requires either legacyidortaskset.id, validates Hub-styleowner/namerefs, and maps evalrollouts_per_example→group_sizefor v1 envs.The init template documents the v1 shape. Pre-run Hub action checks run only for slash-shaped refs (
legacy id,taskset.id,harness.id), not bare runtime ids likealphabet-sort-v1. Run summaries and lists use clearer display names for v1 configs.Reviewed by Cursor Bugbot for commit 7dc15bb. Bugbot is set up for automated code reviews on this repo. Configure here.