Remove feature selection cell from TabPFN_Demo_Local notebook#978
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
alanprior
left a comment
There was a problem hiding this comment.
LGTM, but best if @eliott-kalfon also gives a look as I think he was looking into these things.
|
Hi @alanprior, I was not involved in this but happy to test this on Tuesday morning when I get back. Please do not let my review hold the merge |
eliott-kalfon
left a comment
There was a problem hiding this comment.
@adrian-prior did running the notebook work for you? I get plenty of errors. I will debug on Tuesday. If you want to merge as is, I would still like to fix these next week
|
@eliott-kalfon. That's weird. I think I tried running the notebook (and @LeoGrin, I think, too), and it seemed to run overall (except for some fixes that I implemented). Could you send me the errors you see on Slack? Also, are you running the notebook locally or via colab? |
|
We discussed offline, and the issue was due to the notebook being run in a local setup vs. Colab. I will merge the PR now and possibly create a follow-up PR if additional issues surface. |
Summary
examples/notebooks/TabPFN_Demo_Local.ipynb. -> This is because feature selection is pretty expensive and generally not very helpful for TabPFN (at least using the feature selection extensions).Test plan