Skip to content

Remove feature selection cell from TabPFN_Demo_Local notebook#978

Merged
adrian-prior merged 2 commits into
mainfrom
remove-feature-selection-cell
May 26, 2026
Merged

Remove feature selection cell from TabPFN_Demo_Local notebook#978
adrian-prior merged 2 commits into
mainfrom
remove-feature-selection-cell

Conversation

@adrian-prior

@adrian-prior adrian-prior commented May 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Removes the "### Feature selection" markdown header and the accompanying SFS code cell from examples/notebooks/TabPFN_Demo_Local.ipynb. -> This is because feature selection is pretty expensive and generally not very helpful for TabPFN (at least using the feature selection extensions).

Test plan

  • Open the notebook and confirm the Feature selection section no longer appears between the Embeddings section and the "Predictive Behavior of TabPFN" section.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@adrian-prior adrian-prior marked this pull request as ready for review May 22, 2026 08:36
@adrian-prior adrian-prior requested a review from a team as a code owner May 22, 2026 08:36
@adrian-prior adrian-prior requested review from alanprior and removed request for a team May 22, 2026 08:36

@alanprior alanprior left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but best if @eliott-kalfon also gives a look as I think he was looking into these things.

@alanprior alanprior requested a review from eliott-kalfon May 22, 2026 16:49
@eliott-kalfon

Copy link
Copy Markdown
Contributor

Hi @alanprior, I was not involved in this but happy to test this on Tuesday morning when I get back. Please do not let my review hold the merge

@eliott-kalfon eliott-kalfon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrian-prior did running the notebook work for you? I get plenty of errors. I will debug on Tuesday. If you want to merge as is, I would still like to fix these next week

@adrian-prior

adrian-prior commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

@eliott-kalfon. That's weird. I think I tried running the notebook (and @LeoGrin, I think, too), and it seemed to run overall (except for some fixes that I implemented). Could you send me the errors you see on Slack? Also, are you running the notebook locally or via colab?

@adrian-prior

Copy link
Copy Markdown
Contributor Author

We discussed offline, and the issue was due to the notebook being run in a local setup vs. Colab. I will merge the PR now and possibly create a follow-up PR if additional issues surface.

@adrian-prior adrian-prior added this pull request to the merge queue May 26, 2026
Merged via the queue into main with commit 6db2d4d May 26, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants