Skip to content

fix: fill first empty waypoint slot instead of counting filled waypoints #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wursterje wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

fix: fill first empty waypoint slot instead of counting filled waypoints #480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b64b1ea
fix: fill first empty waypoint slot instead of counting filled waypoints
wursterje Jun 16, 2026
de5c41d
Merge branch 'gh-pages' into gh-pages
DennisOSRM Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,8 @@ map.on('click', function (e) {
});
function addWaypoint(evt) {
var waypoint = evt && evt.latlng ? evt.latlng : evt;
var length = lrmControl.getWaypoints().filter(function(pnt) {
var waypoints = lrmControl.getWaypoints();
var length = waypoints.filter(function(pnt) {
return pnt.latLng;
});
length = length.length;
Expand All @@ -715,11 +716,23 @@ function addWaypoint(evt) {
return;
}
Comment on lines 716 to 717

if (!length) {
lrmControl.spliceWaypoints(0, 1, waypoint);
// Find the first empty waypoint slot.
// Counting filled waypoints and deriving the index from that breaks when
// only the destination is pre-filled via URL (?loc=&loc=<dest>): the single
// filled point sits at index 1, so the old code overwrote the destination
// instead of filling the empty start at index 0.
var emptyIndex = -1;
for (var i = 0; i < waypoints.length; i++) {
if (!waypoints[i].latLng) {
emptyIndex = i;
break;
}
}
if (emptyIndex !== -1) {
lrmControl.spliceWaypoints(emptyIndex, 1, waypoint);
} else {
if (length === 1) length = length + 1;
lrmControl.spliceWaypoints(length - 1, 1, waypoint);
// All slots are filled: replace the last one.
lrmControl.spliceWaypoints(waypoints.length - 1, 1, waypoint);
}
}

Expand Down