Update 08_auction.md#255
Closed
letmejustputthishere wants to merge 1 commit intoProvableHQ:masterfrom
Closed
Conversation
Signed-off-by: Moritz Fuller <32162112+letmejustputthishere@users.noreply.github.com>
Collaborator
|
Thanks for the contributing @letmejustputthishere! |
Collaborator
|
Closing — the substantive change here (program.json → .env) has already been applied to the current auction doc (now at documentation/leo_by_example/01_auction.md). The other half of the PR (dropping the bidder parameter from place_bid in favor of self.caller) depended on ProvableHQ/workshop#40, which didn't land — the canonical auction example still takes bidder explicitly, so the doc correctly matches it. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this assumes that ProvableHQ/workshop#40 is being merged