Skip to content

Update 08_auction.md#255

Closed
letmejustputthishere wants to merge 1 commit intoProvableHQ:masterfrom
letmejustputthishere:patch-3
Closed

Update 08_auction.md#255
letmejustputthishere wants to merge 1 commit intoProvableHQ:masterfrom
letmejustputthishere:patch-3

Conversation

@letmejustputthishere
Copy link
Copy Markdown
Contributor

@letmejustputthishere letmejustputthishere commented Jul 26, 2023

this assumes that ProvableHQ/workshop#40 is being merged

Signed-off-by: Moritz Fuller <32162112+letmejustputthishere@users.noreply.github.com>
@d0cd
Copy link
Copy Markdown
Collaborator

d0cd commented Feb 16, 2025

Thanks for the contributing @letmejustputthishere!
Happy to merge this in after conflicts are resolved.

@mohammadfawaz
Copy link
Copy Markdown
Collaborator

Closing — the substantive change here (program.json → .env) has already been applied to the current auction doc (now at documentation/leo_by_example/01_auction.md). The other half of the PR (dropping the bidder parameter from place_bid in favor of self.caller) depended on ProvableHQ/workshop#40, which didn't land — the canonical auction example still takes bidder explicitly, so the doc correctly matches it. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants