Resolve conflict - #736
Open
TechBroAfrica wants to merge 2 commits into
Open
Conversation
…ngs (FE-52) - Add backend SearchModule, SearchController, and SearchService exposing GET /search API contract - Integrate parallel querying of public profiles and marketplace listings with Levenshtein typo-tolerance (didYouMean) - Create useUnifiedSearch custom hook with debouncing and fallback search logic - Update SearchBar component to render grouped 👤 Profiles and 🏷️ Marketplace Listings - Enhance Discovery page with scope filter tabs (All, Profiles, Listings), loading skeletons, and empty states - Integrate SearchBar into primary navigation Header - Add unit test suite search.controller.spec.ts and implementation walkthrough
Author
|
Hi Maintainer, KIndly review pr. Thanks |
Cedarich
requested changes
Jul 26, 2026
Cedarich
left a comment
Cedarich
left a comment
Contributor
There was a problem hiding this comment.
Kindly fix CI I noticed you changes are 3K+ also fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #680
Here is a concise PR message template for your changes:
Title:
fix(backend): resolve unused variable lint error in search.controller.spec.tsDescription:
🚀 Summary
Resolves the
@typescript-eslint/no-unused-varsCI lint error in search.controller.spec.ts.🛠️ Changes
it('should be defined')test block asserting that bothSearchControllerandSearchServiceare properly instantiated and injected.servicevariable in standard NestJS testing assertions to fix the lint rule while improving test coverage.✅ Verification
@typescript-eslint/no-unused-varssatisfied.